Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate input to input files and folders #131

Open
yucongalicechen opened this issue Nov 20, 2024 · 4 comments
Open

separate input to input files and folders #131

yucongalicechen opened this issue Nov 20, 2024 · 4 comments
Milestone

Comments

@yucongalicechen
Copy link
Collaborator

Problem

CLI takes input files and folders in one argument, but GUI only supports widget for selecting files or folders. Currently the CLI input for GUI is implemented on selecting files. See #130 for more details.

Proposed solution

Separate input to files and folders to match the functionalities in GUI.

@yucongalicechen
Copy link
Collaborator Author

yucongalicechen commented Dec 27, 2024

@sbillinge I'm revisiting this issue. Previously we considered separating input to input files and input folders in gui because it doesn't support widget of selecting multiple files and folders at the same time.
I found that gui also doesn't support multiple folders. Also, since input is a required argument in our CLI, separating it into two arguments would make the requirement on one of the more complicated.
Shall we just allow selecting multiple files for gui? If users need to add a folder, they can either select all files inside it or provide the file path in a text file, or they can just type the folder in the box. I can add a bit more instructions in the help message.

@sbillinge
Copy link
Contributor

yes, that is a good solution. In general, gui's will allow you to CTL-A to select all so it is easy to select everything in a folder.

If we want to have the CLI functionality of globbing a full directory tree, we could allow input to be "glob" or something and then allow the user to set an optional input which would be the path to the top-level directory and the glob pattern.

This may be confusing to non-programmers, so we could hide the functionality a bit, buried in the instructions.

For now, maybe just capture this in an issue that we can backburner for the future if it is asked for, and do it the way you suggest.

@yucongalicechen
Copy link
Collaborator Author

Yeah I think we already have glob functionality in CLI. I'll keep this issue open then and clarify about the widget either in docs or through help messages.

@sbillinge
Copy link
Contributor

Yeah I think we already have glob functionality in CLI. I'll keep this issue open then and clarify about the widget either in docs or through help messages.

yes, this is very useful for our more pythony command line folks, so it would be sad to lose it completely if we can figure out how to handle it in the gui (which is for our non-pythony users)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants