Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of invalid origins in the config #76

Open
lazka opened this issue Jun 7, 2023 · 0 comments
Open

Better handling of invalid origins in the config #76

lazka opened this issue Jun 7, 2023 · 0 comments

Comments

@lazka
Copy link
Member

lazka commented Jun 7, 2023

We just had one user adding https://foo.bar.org/ into the config, which didn't work because of the trailing slash and the origin being https://foo.bar.org.

We should either:

  • Validate the input somehow and show an error to the user, to make sure the origins are all in the correct format
  • Or allow this specific case and strip trailing slashes

(I kinda prefer (1) because it covers more cases)

Somewhat related, I wonder if we support explicit ports like http://foo.bar.org:80 in that case ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant