This repository has been archived by the owner on Jan 8, 2022. It is now read-only.
types: union value types on intersect and difference
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImRodry
reviewed
Jan 2, 2022
suneettipirneni
changed the title
intersect and difference when types are differentintersect and difference
|
I don't understand why it's for (const [k, v] of other) {
if (this.has(k)) coll.set(k, v);
}The values in the new collection are coming straight from collection |
This is true for const coll = new this.constructor[Symbol.species]<K, V | T>();
for (const [k, v] of other) {
if (!this.has(k)) coll.set(k, v);
}
for (const [k, v] of this) {
if (!other.has(k)) coll.set(k, v);
} |
|
Oh, sorry, I missed that 😅 |
SpaceEEC
approved these changes
Jan 3, 2022
kyranet
approved these changes
Jan 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Closes #55
intersectanddifferencewill provide a collection with a value type that is a union of the collection value type and value type of the collection to run against. Just like before, you need to have a matching key type.For example:
Performing an
intersectionofCollection<string, string>onto aCollection<string, number>will yield the typeCollection<string, number>;Performing an
differenceofCollection<string, string>onto aCollection<string, number>will yield the typeCollection<string, string | number>;Performing an
intersectionordifferenceon aCollection<string, string>and aCollection<number, string>is an error since key types don't match.Status and versioning classification: