Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erlazure:get_host to pull from state #27

Open
petermueller opened this issue Mar 13, 2018 · 2 comments
Open

erlazure:get_host to pull from state #27

petermueller opened this issue Mar 13, 2018 · 2 comments

Comments

@petermueller
Copy link

petermueller commented Mar 13, 2018 •
edited
Loading

I appreciate your work on this library.

What would you say to having get_host be a handle_call and pull from the state of the actor instead, and default it to use the core.windows.net domain if nothing else is configured? We're looking at running functional tests and it would be neat to use azurite in a container for running the more basic tests.

EDIT: If you are interested but swamped and would prefer I make a PR to review, I can take a swipe at it.
@dkataskin
Copy link
Owner

Hi, sure, if you can make a PR that would be great, otherwise I will try to find time in the next days to add this call.

ariel-anieli added a commit to ariel-anieli/erlazure that referenced this issue Dec 21, 2023
@ariel-anieli
get_host/3 exposed thru gen_server; PR for dkataskin#27
5a6c14d
dkataskin added a commit that referenced this issue Dec 22, 2023
@dkataskin
Merge pull request #37 from ariel-anieli/issue-27-get-host-as-handle-…
c0b90d5 
…call

get_host/3 exposed thru gen_server; PR for #27
@ariel-anieli
Copy link

Closed by #37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dkataskin @petermueller @ariel-anieli