Revision Machine tests failing when executed on machines with non-CEST compatible timezones

[tgalery]

Not sure if I have something misconfigured, but just pulled the most recent master to work on #159 and when trying to install dkpro-jwlp I got the following error in the tests:

[ERROR] Failures:
[ERROR]   RevisionApiTest.articleIDTests:183 expected:<2004-04-07 0[2]:31:34.0> but was:<2004-04-07 0[1]:31:34.0>
[INFO]
[ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] JWPL ............................................... SUCCESS [  4.769 s]
[INFO] Java Wikipedia API ................................. SUCCESS [ 28.459 s]
[INFO] MediaWiki Dumper ................................... SUCCESS [  0.917 s]
[INFO] WikiMachine ........................................ SUCCESS [  0.287 s]
[INFO] DataMachine ........................................ SUCCESS [  3.122 s]
[INFO] TimeMachine ........................................ SUCCESS [  2.473 s]
[INFO] RevisionMachine .................................... FAILURE [  5.222 s]
[INFO] MediaWiki Parser ................................... SKIPPED
[INFO] JWPL API and RevisionAPI Utilities ................. SKIPPED
[INFO] JWPL Tutorial ...................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 45.474 s
[INFO] Finished at: 2018-07-25T11:03:59+01:00
[INFO] Final Memory: 120M/1222M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test (default-test) on project de.tudarmstadt.ukp.wikipedia.revisionmachine: There are test failures.
[ERROR]
[ERROR] Please refer to /Users/thiago/code/tgalery/dkpro-jwpl/de.tudarmstadt.ukp.wikipedia.revisionmachine/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream.

Is someone able to replicate it ? Why isn't travis picking that up ? Should I tackle as part of #159 ?

[tgalery]

It looks like it's something related to how the embedded is created.

diff --git a/de.tudarmstadt.ukp.wikipedia.revisionmachine/src/test/resources/db/wikiapi_simple_20090119_stripped.properties b/de.tudarmstadt.ukp.wikipedia.revisionmachine/src/test/resources/db/wikiapi_simple_20090119_stripped.properties
index 8afab5b8..f31574c9 100644
--- a/de.tudarmstadt.ukp.wikipedia.revisionmachine/src/test/resources/db/wikiapi_simple_20090119_stripped.properties
+++ b/de.tudarmstadt.ukp.wikipedia.revisionmachine/src/test/resources/db/wikiapi_simple_20090119_stripped.properties
@@ -1,5 +1,5 @@
 #HSQL Database Engine 2.4.0
-#Tue Jul 17 10:22:21 CEST 2018
+#Wed Jul 25 11:23:45 BST 2018

[reckart]

Yep - looks like the test doesn't take time-zones into account.

[mawiesne]

@tgalery I think wikiapi_simple_20090119_stripped.properties should be removed from the repo. Probably, it's a left-over from work in #2. Please delete it locally. Maybe this should fix it?
Also: Add it to .gitignore (or a pattern that matches "wikiapi_*.properties"), as it will be recreated automatically on each local run on dev-machines during builds. Therefore, we want to avoid simple file deltas to be added for each build.

If not: check whether the related .script file contains timestamps in localized format.

[tgalery]

Cool, will do that as part of #159, thanks for the help!

[mawiesne]

@tgalery I thought about this issue and as a result wanted to check with you whether it would better to tackle this issue here separate from #159?

In general, it's reported clear enough, so I could tackle it.

[tgalery]

@mawiesne sorry for the delay. Yeah if you wanna tackle this separately, go for it (they are independent anyway)!