Replies: 2 comments 1 reply
-
@lucas-angermann, @voinSR, @MichaelLangbein, @kambrium what do you think about this? |
Beta Was this translation helpful? Give feedback.
0 replies
-
Didn't quite understand that aspect - could you elaborate? That said, having ukis a bit more modular seems like a good thing, and maybe this does make development of the cesium- and maplibre-branches a bit faster. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently we have a mix of different mapping libraries and many things in this repository.
To simplify dependency management and maintenance, maybe it would be good to remove all mapping library dependent things.
These could then be published in separate repositories.
E.g.
ukis-core
projects/base-layers-raster
projects/core-ui
projects/layer-control
projects/services-layers
projects/services-map-state
projects/services-ogc
projects/services-util-store
projects/shared-assets
projects/utils-browser
projects/utils-ogc
@dlr-eoc/map-ol
projects/map-ol
projects/utils-maps/src/lib/ol
projects/utils-ogc/src/lib/wms
projects/map-tools/src/lib/mouse-position
projects/services-ogc/src/lib/owc
@dlr-eoc/map-three
projects/map-three
demo-maps
projects/demo-maps
demo-auth
and@dlr-eoc/user-info
projects/demo-auth
projects/user-info
and other upcoming mapping libraries
@dlr-eoc/map-leaflet
@dlr-eoc/map-maplibre
@dlr-eoc/map-cesium
Disadvantages
ukis-core
) as npm dependencies or with some cloning and path mappingOn the one hand, that's good because we don't have to update all projects at one time but we'll have to update them later anyway.
This can lead to different versions e.g. angular of
[email protected]
,@dlr-eoc/[email protected]
and@dlr-eoc/[email protected]
which can result to different behavior.-> However, this can lead to more difficult migrations if a project waits too long.
-> Shared libraries must work for all versions of the projects or the projects must be updated when the libraries change
-> Fixes in shared libraries are not so easy to integrate -> Fix, publish, then include (npm) -> needs more automation in deployment
Advantages
Beta Was this translation helpful? Give feedback.
All reactions