Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About evaluation metric #18

Open
zyqz97 opened this issue Jan 7, 2025 · 2 comments
Open

About evaluation metric #18

zyqz97 opened this issue Jan 7, 2025 · 2 comments
Assignees

Comments

@zyqz97
Copy link

zyqz97 commented Jan 7, 2025

Hello, I have a new question.
The metrics obtained from the released checkpoint differ from those reported in the paper.
I run the following scripts :

get refine image: resolution is 448 x 256

python -m src.main +experiment=dl3dv_mvsplat360 \ wandb.name=dl3dv_480P_ctx5_tgt56 \ mode=test \ dataset/view_sampler=evaluation \ dataset.roots=[datasets/dl3dv] \ checkpointing.load=checkpoints/dl3dv_480p.ckpt

color adjustment

python src/scripts/post_process.py --root_dir=outputs/test_scores/dl3dv_480P_ctx5_tgt56_download_ckpt

compute the metric

python -m src.scripts.compute_dl3dv_metrics --use_pp

and I modified the compute_dl3dv_metrics.py to read folder.

image

But I get the metric below, which is different from the paper:
image and FID: 16.43
image

So, I’d like to ask if I might have missed some details when evaluating. Thanks!

@donydchen
Copy link
Owner

Hi @zyqz97, when testing the PSNR and SSIM, we find it better to run all 56 frames through the SVD (modify the eval command by appending model.refiner.svd_num_frames=56 model.refiner.test_time_attn_num_splits=4), after that, apply the color adjustment post-processing before running the evaluation.

Still, even using the README-provided evaluation commands, the performance should be slightly better than the one you obtained since the modifications I mentioned above are better for visual quality but only bring a small gain for the quantitative results. Perhaps there might be some issues with the data processing codes since it is supposed to be a one-off for now. I will find time to clean those parts of the codes in the future.

@donydchen donydchen self-assigned this Jan 7, 2025
@zyqz97
Copy link
Author

zyqz97 commented Jan 8, 2025

Thanks for your reply!

I implemented the modifications you suggested (model.refiner.svd_num_frames=56 model.refiner.test_time_attn_num_splits=4). As you said, while the metrics have improved slightly, they still don't quite match the results reported in the paper.

As for the data processing, I used the code from DepthSplat. I'm looking forward to the updates of your code. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants