Our tools should format messages to match GitHub's UI format #1125
Comments
|
Sounds good to me, thanks :) |
This was referenced Jun 24, 2024
BillWagner
added a commit
to BillWagner/csharpstandard
that referenced
this issue
Sep 19, 2024
Contributes to dotnet#1125 Replace the existing logging code with the utility class that writes to the console, and adds a status check record. Log failures as status checks, but status is only to the output console.
|
The only tool remaining to hook into this mechanism is the grammar validator. That might be able to do it using curl, but let's wait a bit until the next updates are in place. |
BillWagner
added a commit
that referenced
this issue
Oct 4, 2024
* Add status checks to the test runner Contributes to #1125 Replace the existing logging code with the utility class that writes to the console, and adds a status check record. Log failures as status checks, but status is only to the output console. * Update tools/Utilities/StatusCheckLogger.cs * Apply suggestions from code review * Feedback from code review A bit of refactoring.
BillWagner
added a commit
to BillWagner/csharpstandard
that referenced
this issue
Dec 4, 2024
Search for instances of "the compiler" and where the text describes what a compliant compiler is is required or allowed to do, replace "the compiler" with "a compiler". Where necessary, include "shall" or "may", as appropriate. There are still instances of "the compiler" in the standard. Some are in types.md. Those are addressed in dotnet#1125. Others are where the text describes "the compiler generated" backing field, class, or method.
BillWagner
added a commit
that referenced
this issue
Dec 11, 2024
* The compiler -> a compiler Search for instances of "the compiler" and where the text describes what a compliant compiler is is required or allowed to do, replace "the compiler" with "a compiler". Where necessary, include "shall" or "may", as appropriate. There are still instances of "the compiler" in the standard. Some are in types.md. Those are addressed in #1125. Others are where the text describes "the compiler generated" backing field, class, or method. * fix typo * respond to feedback. * Update standard/classes.md Co-authored-by: Nigel-Ecma <[email protected]> * Update standard/classes.md Co-authored-by: Bill Wagner <[email protected]> --------- Co-authored-by: Rex Jaeschke <[email protected]> Co-authored-by: Jon Skeet <[email protected]> Co-authored-by: Nigel-Ecma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should format the error output for the TOC / anchor generator, Word generator, and the test extractor so that they participate in the GitHub PR Review process as markdownlint lint does.
@jskeet I'll take this on in a combination of 3 PRs if you want.
The text was updated successfully, but these errors were encountered: