Validate VMR Shipping Packages #45836
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ellahathaway
force-pushed
the
validate-signed-artifacts
branch
from
2ff6121 to
c818ebe
Compare
|
Test run (internal Microsoft link) |
|
Awesome!!!! |
mmitche
reviewed
Jan 24, 2025
mmitche
approved these changes
Jan 24, 2025
mmitche
approved these changes
Jan 24, 2025
|
Will this break official builds until the linked issue is resolved? Or is the error just ignored? |
The stage warns currently |
ViktorHofer
approved these changes
Jan 25, 2025
This was referenced Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dotnet/source-build#4068
When not all packages are signed, the validation stage is marked with a warning and an error message is outputted to the UI.
Note: Until dotnet/source-build#4678 is resolved, the validation stage will output the error that not all packages are signed. This is because mac & linux builds are currently doing dry-run signing.