Do not set RestoreConfigFile in environment #46101
Conversation
Internal tool restore requires use a separate nuget.config. Setting this globally causes issues.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
| @@ -154,9 +154,6 @@ | |||
|
|
|||
| <!-- Need to be passed in as an env var so that custom Exec tasks in the repo's DotNetBuild.props receive this setting. --> | |||
| <EnvironmentVariables Include="DotNetPackageVersionPropsPath=$(PackageVersionPropsPath)" /> | |||
|
|
|||
| <!-- Needed for miscellanous projects in various repos - see https://github.com/dotnet/source-build/issues/4081--> | |||
There was a problem hiding this comment.
What has changed to address dotnet/source-build#4081?
There was a problem hiding this comment.
Nothing yet. This PR was essentially to go find the places that need alteration.
|
@NikolaMilosavljevic Do you happen to know what issue you saw with source-build-externals? Did the build break, or something else? |
I'll try to track that down. |
@NikolaMilosavljevic It looks like the offline leg is where the failures pop up, so I think I'm good. |
Internal tool restore requires use a separate nuget.config. Setting this globally causes issues.