Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider running Publish target when _IsPublishing is true #46279

Open
sbomer opened this issue Jan 24, 2025 · 2 comments
Open

Consider running Publish target when _IsPublishing is true #46279

sbomer opened this issue Jan 24, 2025 · 2 comments
Labels
untriaged Request triage from a team member

Comments

@sbomer
Copy link
Member

sbomer commented Jan 24, 2025

For folks who don't use dotnet publish, it's a common pattern to inject the Publish target so that they can run msbuild without specifying /t:Publish. See examples from #37872 (comment):

Lots of people do that, some of them even pass _IsPublishing but most of them just do some variation of "run the Publish target". Here is a popular pattern (note these are all pretty high profile).

This won't fully replicate the effects of dotnet publish unless they also pass -p:_IsPublishing=true. Would it make sense to run the Publish target after Build when _IsPublishing is set, so that folks using msbuild can at least do msbuild -p:_IsPublishing=true and get the same output as dotnet publish? (We wouldn't advertise that until it's made public, see #26324)

@MichalStrehovsky @rainersigwald @marcpopMSFT @dsplaisted @agocke

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Jan 24, 2025
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untriaged Request triage from a team member
Projects
None yet
Development

No branches or pull requests

1 participant