Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize check_pre to handle singe and comparative analysis correctly #304

Open
codyroux opened this issue Mar 15, 2021 · 0 comments
Open
Assignees

Comments

@codyroux
Copy link
Contributor

codyroux commented Mar 15, 2021

Currently we have combined_pre (

type combined_pre = {
) as the input type to the check_pre function (and therefore the output of single and comparative.

The problem is that this type assumes both orig and modif fields (env * sub term pairs) exist, which is not always the case.

We should fix this, as it is already causing problems with some branches, and will surely be a source of issues in the future.

My recommendation would be to have a wrapper type type check_res = Single of ?? | Double of ?? which handles both possibilities, and pass that around to check_pre and Output.print_result, which can then operate as needed.

But there are many possible approaches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants