-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ascension / Tilt does not adhere to Rotation / Flip #1423
Comments
By passing the view rotation into the MyPaint engine and flipping the x and y tilt as appropriate. Relates to #1423.
I've made an attempted fix. Mirroring and flipping the canvas now flip the tilt inputs, so that should now work I think. The canvas rotation is also now passed into the brush engine, which seems like it should lead to correct behavior, given what the internal values end up being, but testing it I don't know if it really is working properly. I may be misunderstanding the intended behavior though, since I never use tilt dynamics myself. Can you test how this is working? It's available in the alpha release https://github.com/drawpile/Drawpile/releases/tag/continuous If it doesn't behave properly, can you also try how the brushes behave in MyPaint? That is where the brush engine comes from and would help figure out if it's working properly there: https://mypaint.app/ I unfortunately can't test MyPaint properly myself because the only device I have that supports tilt is an Android tablet. |
Just tested Angular Offset: View |
Behavior between both MyPaint and DrawPile now appear to be in parity. ... which means I've just found a bug in both
Apologies for morphing the bug a bit. If you'd rather I log a separate one lmk. |
Alright thanks for testing, that confirms my suspicions. I guess I'll try to pre-rotate the tilt inputs then, since the engine evidently doesn't handle it properly. It'd be consistent with how I solved mirroring and flipping since there's no other way to tell the brush engine about it. It may have knock-on effects in cases where the MyPaint engine does correctly apply the view rotation, but those are pretty obvious in the code and can be removed. It's fine to keep it all in one ticket, since the user-facing issue is still the same. |
When applying Ascension / Tilt to a brush, it will not adhere to any Rotation / Flip.
REPRO:
Set up a brush to utilize Ascension / Tilt in some way
- I.E.: Elliptical dab : angle > Ascension > Value: 90.00 > Output 180 / Min -180 / Max 180
- Brushes attached are set up for Ascension / Tilt: TILT BRUSHES.zip
Set: 0% Rotation / Horizontal Flip disabled
confirm the brush adheres to the user's Ascension / tilt.
Set: Any non-0% Rotation or Flip enabled
confirm the brush adheres to the user's Ascension / tilt.
EXPECTED:
Ascension / Tilt will adhere to any Rotation / Flip
RESULTS:
Ascension / Tilt does not adjust to fit user's current Rotation / Flip
IMPACT:
User cannot effectively utilize Ascension / Tilt at any non-0% Rotation / Flip
Video attached:
https://github.com/user-attachments/assets/07e1fcd7-17e7-4c18-b868-f1ae7c12a6ad
The text was updated successfully, but these errors were encountered: