-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ir-test: Improve console args handling #18
Conversation
Signed-off-by: Anatol Belski <[email protected]>
Signed-off-by: Anatol Belski <[email protected]>
Signed-off-by: Anatol Belski <[email protected]>
Signed-off-by: Anatol Belski <[email protected]>
I'm not sure if this simplifies anything. In general, we don't need It's better to pass a list of test directories without e.g. I would also think about this tester program independently from IR project, especially if we move it to separate folder. Name it |
Thanks for checking this. I guess the difference is on the views with regard to the intention. As per the title here and in the linked issue, it meant New options can come, like those you mention. Some options would be most likely a secondary consequence when adding more features. Say others like diff or parallelization can be controlled from the cmdline interface. Now with what you've suggested to support Of course, taking
If renaming, maybe Perhaps adding more code and depending on more code is not that bad. It's just the price for a better featured tool. Reusing such external classes as a drop-in functionality is very easy and efficient. I see your point however, that this kind of code and extensive tooling possibly doesn't belong into this repo. Thanks |
Abandoning this one for now. The change is too extensive and leads the focus away from the main dev subject. The present functionality is good enough to serve the project. Any further functionality is to be supplied in a minimalistic manner, as the need arises. Thanks |
The console arg parsing functionality is pulled through a dedicated class. The license is MIT which seems compatible with the IR license.
The
ir-test
program code is moved undermisc-utils
subdirectory, where the arg parsing library is added as well. The current options have been migrated to the new class, some more options have been added for a better flexibility.Especially there are two new options to pass
BUILD_DIR
andSRC_DIR
, that would override the corresponding environment variables if supplied. Otherwise, the env variables will be used, thus maintaining the backward compatible behavior.The help output is automatically generated by the arg parsing library:
Unknown options would make the program bail out:
While on this change, several exception handling arguments have been constified to comply better with the other parts of the code.
Fixes: #10