Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 🐛 (Chess): Take back breaks time control #2

Open
ZaymonFC opened this issue Feb 14, 2024 · 0 comments
Open

Bug 🐛 (Chess): Take back breaks time control #2

ZaymonFC opened this issue Feb 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ZaymonFC
Copy link
Contributor

ZaymonFC commented Feb 14, 2024 •
edited
Loading

Taking back a move doesn't account for the time elapsed.

Possible solution: time control code could have a courtesy time array which we append the elapsed time to. This would also unlock 'give time +15s' or something similar.

Relevant code: https://github.com/dxos/arena-app/blob/7b9ffc5edfea9c5a497469c0ba25ee975d8eedbe/src/plugins/Chess/hooks/useTimeControl.ts#L53C1-L76C3
@ZaymonFC ZaymonFC changed the title Bug 🐛 (Chess) - Take back breaks time control Bug 🐛 (Chess): Take back breaks time control Feb 14, 2024
@ZaymonFC ZaymonFC added the bug Something isn't working label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZaymonFC