-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not alter Copyright notice in files that contain "DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER" #9
Comments
I first saw PR #10 and then read this Issue. I don't understand the meaning behind this "DO NOT ALTER..." copyright. I can understand the "DO NOT..REMOVE..." aspects, but why can't it be altered. And, if it really can't be altered (ie. the dates), then does the presence of this statement require us to create a new copyright in addition to this existing one? Something would allow us to make updates in the future under the Jakarta EE project? |
Good question about the meaning of the "DO NOT ALTER" copyright, I believe that first came up via jakartaee-tck/pull/194. https://gist.github.com/scottmarlow/0e2c3649786365955cc0024d7e7a694e contains the files that have "DO NOT ALTER" copyright: Also note #15 Update lib/schemas references (e.g. install, release, tests under src) to use either EE 9 or Jakarta EE 8 schemas (as per Jan 21, 2020 VOTE: backward compatibility for descriptor schemas), perhaps we should instead replace all of the XML document type definitions + schema definitions, with EE 9 replacements. IMO, we could ask on a mailing list for input on how we should handle the TCK lib/schemas + lib/dtds when making updates, in case we keep these files. |
I asked on the TCK ML about this (please see "About copyright plugin potential fix" thread). |
Should the plugin ignore files that contain "DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER"?
Jakarta EE Platform TCK pr # 222 (javax.jms to jakarta.jms) shows what happens when the GlassFish Copyright Plugin is used to modify a file that shouldn't be changed:
The text was updated successfully, but these errors were encountered: