Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not alter Copyright notice in files that contain "DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER" #9

Open
scottmarlow opened this issue Apr 29, 2020 · 3 comments · May be fixed by #10

Comments

@scottmarlow
Copy link
Member

Should the plugin ignore files that contain "DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER"?

Jakarta EE Platform TCK pr # 222 (javax.jms to jakarta.jms) shows what happens when the GlassFish Copyright Plugin is used to modify a file that shouldn't be changed:

diff --git a/lib/dtds/connector_1_6.dtd b/lib/dtds/connector_1_6.dtd
index 9bf099075..9aacf93ea 100644
--- a/lib/dtds/connector_1_6.dtd
+++ b/lib/dtds/connector_1_6.dtd
@@ -2,33 +2,15 @@
- DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
- 
- Copyright 1997-2007 Sun Microsystems, Inc. All rights reserved.
- 
- The contents of this file are subject to the terms of either the GNU
- General Public License Version 2 only ("GPL") or the Common Development
- and Distribution License("CDDL") (collectively, the "License").  You
- may not use this file except in compliance with the License. You can obtain
- a copy of the License at https://glassfish.dev.java.net/public/CDDL+GPL.html
- or glassfish/bootstrap/legal/LICENSE.txt.  See the License for the specific
- language governing permissions and limitations under the License.
- 
- When distributing the software, include this License Header Notice in each
- file and include the License file at glassfish/bootstrap/legal/LICENSE.txt.
- Sun designates this particular file as subject to the "Classpath" exception
- as provided by Sun in the GPL Version 2 section of the License file that
- accompanied this code.  If applicable, add the following below the License
- Header, with the fields enclosed by brackets [] replaced by your own
- identifying information: "Portions Copyrighted [year]
- [name of copyright owner]"
- 
- Contributor(s):
- 
- If you wish your version of this file to be governed by only the CDDL or
- only the GPL Version 2, indicate your decision by adding "[Contributor]
- elects to include this software in this distribution under the [CDDL or GPL
- Version 2] license."  If you don't indicate a single choice of license, a
- recipient has the option to distribute your version of this file under
- either the CDDL, the GPL Version 2 or to extend the choice of license to
- its licensees as provided above.  However, if you add GPL Version 2 code
- and therefore, elected the GPL Version 2 license, then the option applies
- only if the new code is made subject to such option by the copyright
- holder.
+
+    Copyright (c) 1997, 2020 Oracle and/or its affiliates. All rights reserved.
+
+    This program and the accompanying materials are made available under the
+    terms of the Eclipse Public License v. 2.0, which is available at
+    http://www.eclipse.org/legal/epl-2.0.
+
+    This Source Code may also be made available under the following Secondary
+    Licenses when the conditions for such availability set forth in the
+    Eclipse Public License v. 2.0 are satisfied: GNU General Public License,
+    version 2 with the GNU Classpath Exception, which is available at
+    https://www.gnu.org/software/classpath/license.html.
+
+    SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
@kwsutter
Copy link

kwsutter commented May 4, 2020

I first saw PR #10 and then read this Issue. I don't understand the meaning behind this "DO NOT ALTER..." copyright. I can understand the "DO NOT..REMOVE..." aspects, but why can't it be altered. And, if it really can't be altered (ie. the dates), then does the presence of this statement require us to create a new copyright in addition to this existing one? Something would allow us to make updates in the future under the Jakarta EE project?

@scottmarlow
Copy link
Member Author

scottmarlow commented May 4, 2020

Good question about the meaning of the "DO NOT ALTER" copyright, I believe that first came up via jakartaee-tck/pull/194.

https://gist.github.com/scottmarlow/0e2c3649786365955cc0024d7e7a694e contains the files that have "DO NOT ALTER" copyright:
jakartaee-tck/lib/dtds
jakartaee-tck/lib/schemas

Also note #15 Update lib/schemas references (e.g. install, release, tests under src) to use either EE 9 or Jakarta EE 8 schemas (as per Jan 21, 2020 VOTE: backward compatibility for descriptor schemas), perhaps we should instead replace all of the XML document type definitions + schema definitions, with EE 9 replacements.

IMO, we could ask on a mailing list for input on how we should handle the TCK lib/schemas + lib/dtds when making updates, in case we keep these files.

@scottmarlow
Copy link
Member Author

I asked on the TCK ML about this (please see "About copyright plugin potential fix" thread).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants