Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HostnameResolver class initialization is pretty heavy #5429

Open
geoand opened this issue Dec 30, 2024 · 3 comments · May be fixed by #5439
Open

HostnameResolver class initialization is pretty heavy #5429

geoand opened this issue Dec 30, 2024 · 3 comments · May be fixed by #5439
Labels
enhancement help wanted

Comments

@geoand
Copy link
Contributor

geoand commented Dec 30, 2024

This class is loaded as part of the initialization of AddressResolverOptions, but the way it tries to extract the ndots and rotate configuration is pretty heavy (and shows up in flamegrapahs for startup of a Quarkus application).

I believe it could be made to not use regular expressions and also pull all the options in a single pass, no?
@geoand geoand added the bug label Dec 30, 2024
@tsegismont
Copy link
Contributor

That's possible, if you'd like to contribute such an enhancement, please go ahead and send a PR (ideally with a benchmark)

@geoand
Copy link
Contributor Author

geoand commented Jan 3, 2025

I'll keep it on my radar

geoand added a commit to geoand/vert.x that referenced this issue Jan 10, 2025
@geoand
Use simple parser instead of regex for parsing resolv.conf
534e14e 
Closes: eclipse-vertx#5429
@geoand geoand linked a pull request Jan 10, 2025 that will close this issue
Open
@geoand
Copy link
Contributor Author

geoand commented Jan 10, 2025

#5439 is what I have in mind

geoand added a commit to geoand/vert.x that referenced this issue Jan 14, 2025
@geoand
Use simple parser instead of regex for parsing resolv.conf
d96a346 
Closes: eclipse-vertx#5429
geoand added a commit to geoand/vert.x that referenced this issue Jan 14, 2025
@geoand
Use simple parser instead of regex for parsing resolv.conf
316fecd 
Closes: eclipse-vertx#5429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use simple parser instead of regex for parsing resolv.conf geoand/vert.x
2 participants
@tsegismont @geoand