launcher exits the VM with status code 0 when an exception is thrown VertxApplicationHooks

[bitkid]

if i put a throw Exception("bla") into one of the application hooks (f.ex. in afterVertxStarted) the JVM exits with status 0. i think it should not.

[tsegismont]

Thanks for reporting this @bitkid

[tsegismont]

@bitkid I've added a couple of tests in 76672e4 and couldn't reproduce your issue.

Can you share a small snippet that fails your expectations with 5.0.0.CR3?

[bitkid]

this is not working

[tsegismont]

Please share a small snippet that fails your expectations with 5.0.0.CR3

[bitkid]

https://gist.github.com/bitkid/30456f73833b9074e3ac39704256d4e2

this is the simple test code.

i put it into a fat jar and start it with

java -cp the-all.jar Launchie

it writes

"throw exception" in the shell

and when i do echo $? it returns 0

[bitkid]

ok, so i looked at your tests .. do i have to do

System.exit(app.launch()) ?

if so, you can just close the ticket and document it somewhere?

[bitkid]

ah ok .. System.exit() is only called when the exit code is 2 .. what's the reason behind that? because if the beforeStartingVertx throws exit code is 1 @tsegismont