Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string comparison to LLVM backend #748

Closed
jiribenes opened this issue Dec 13, 2024 · 1 comment · Fixed by #771
Closed

Add string comparison to LLVM backend #748

jiribenes opened this issue Dec 13, 2024 · 1 comment · Fixed by #771
Assignees
@mattisboeckle
Labels
area:llvm

Comments

@jiribenes
Copy link
Contributor

jiribenes commented Dec 13, 2024 •
edited
Loading

I'd like to have a function compareStringBytes: (String, String) => Ordering for #561.
See #561's changes in effekt.effekt for the kind of function we need, then figure out a way to support it on the LLVM backend. :)

Should it be native (somewhere in C)? Should it be written in Effekt itself? No clue.
I think it should be possible and reasonably easy to write this function directly in Effekt, at least if the comparison is byte-wise.
@jiribenes jiribenes mentioned this issue Dec 13, 2024
Merged
@jiribenes
Copy link
Contributor Author

At the Effekt Working Group Meeting ™️, we talked about this: perhaps having a comparison returning -1, 0, 1 on native byte strings would make sense, then we can just set compareString to use s1.toByteString.compare(s2.toByteString)

@mattisboeckle mattisboeckle mentioned this issue Jan 10, 2025
Merged
b-studios pushed a commit that referenced this issue Jan 23, 2025
@jiribenes
Add immutable ordered finite 'map' and 'set' to the stdlib (#561)
2be5198 
I've been sitting on this code for almost ~~9~~ _13_ months now (started
on Xmas 2023), it's about time we finalise it.
This PR adds immutable ordered maps and sets based on weight balanced
trees into the standard library.

The `map` and `set` now work on all main backends: JS, LLVM, Chez.

Progress ~~is **blocked**~~ was blocked on:
1. ~~very annoying inliner bug(s?) [#733]~~ _resolved_ 🥳 
2. ~~missing comparisons on strings on LLVM [#748]~~ _resolved_ 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattisboeckle mattisboeckle

Labels
area:llvm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement compare for bytearray mattisboeckle/effekt
2 participants
@jiribenes @mattisboeckle