Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the C++ version of edge #10

Open
waynelapierre opened this issue Aug 24, 2024 · 2 comments
Open

Optimize the C++ version of edge #10

waynelapierre opened this issue Aug 24, 2024 · 2 comments

Comments

@waynelapierre
Copy link

I find the current bidask::edge function quite slow. Since you already have edge coded in C++, could you port it to the R package using Rcpp? Also, some parts of the C++ edge function can be parallelized using OpenMP.

@eguidotti
Copy link
Owner

Nice! Yes, I can try the port to R but I don't know how to parallelize the code in C++. Would you be able to help there?

@eguidotti eguidotti changed the title port C++ version of edge to R Optimize the C++ version of edge Dec 24, 2024
@eguidotti
Copy link
Owner

The C++ version will not be ported to R because the Rcpp package is licensed under GPL and I want to license the R package (and possibly all implementations) under the more permissive MIT license. See #15

The R and Python versions now includes the functions edge_rolling and edge_expanding that are optimized for fast calculations over rolling and expanding windows.

Yet, the C++ version can be optimized indeed. Any help is greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants