I can't seem to be able to login

[Mathieubola]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem
  • Checked that your issue isn't already filed: Issues

Description

I'm really sorry if I just didn't understand how to login but I can't seem to be able to, despite of my best efforts.

I put my logins in the input, but nothing happens when I press enter or when I click on login.

I'm sure my logins are correct (I tested them because I had doubt) and I tried deactivating all the others plugins and it still doesn't work.

Steps to Reproduce

1. Install the plugin
2. Reload VScode
3. Enter my logins
4. Press enter / Click on login

Expected behavior: A change like showed in the gif form the plugin Detail page.

Actual behavior: Nothing. Not a change, not a login, even after a minute or two.

Reproduces how often: 100%

Versions

code -v :

1.53.1
5d424b828ada08e1eb9f95d6cb41120234ef57c7
x64

code --list-extensions --show-versions :

[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

Additional Information

I use the official version of visual studio code from the Microsoft repository (http://packages.microsoft.com/repos/code stable).
I'm also on Linux Mint 20.1.

[ekarbe]

Seems to be an issue with the reddit endpoint I'm using. I even expected something like this to happen as I use some hacky ways to access the user interface.
Even with correct data (encoded and unencoded) I get a 200 with an error json containing the "wrong password" error.

I will probably look into this tomorow or on sunday. Or if you'e feeling bored you could do it. This would be the next step:

• Test https://ssl.reddit.com/api/login/$USERNAME$?api_type=json&username=$USERNAME$&password=$PASSWORD$ endpoints functionality
• Optional: Add check on response.result.json.errors to catch failed logins

[Mathieubola]

I couldn't make your endpoint work but I looked at stackoverflow and I think the login using the api work differently (maybe it has changed some time ago).

In curl it looks like this curl -duser=USERNAME -dpasswd=PASSWORD -dapi_type=json https://ssl.reddit.com/api/login.

I'll try to add it into your project soon but it will be the first time I participate to a project like this so don't hesitate to correct me if I'm wrong.

Anyway, thank you for your response and sorry for responding so late 😅 .

[ekarbe]

In curl it looks like this curl -duser=USERNAME -dpasswd=PASSWORD -dapi_type=json https://ssl.reddit.com/api/login.

Another possibilty could be the POST from https://www.reddit.com/login or changing the ssl.reddit to old.reddit.
They didn't work in the beginning but maybe times have changed.

The last resort would be to implement OAuth. But this would probably be a PITA as this is not an usual web-app.