Cloud Defend binary missing from 8.17.0+ containers

[cmacknz]

docker run -it --entrypoint /bin/bash docker.elastic.co/elastic-agent/elastic-agent:8.17.0
elastic-agent@f048b436b7c0:~$ ls data/elastic-agent-96f2b9/components/
LICENSE.txt                       bundle.tar.gz                    java-attacher.jar
NOTICE.pf-elastic-collector.txt   certs                            lenses
NOTICE.pf-elastic-symbolizer.txt  checksum.yml                     module
NOTICE.pf-host-agent.txt          cloudbeat                        osquery-extension.ext
NOTICE.txt                        cloudbeat.spec.yml               osqueryd
README.md                         cloudbeat.yml                    pf-elastic-collector
agentbeat                         endpoint-security                pf-elastic-collector.spec.yml
agentbeat.spec.yml                endpoint-security-resources.zip  pf-elastic-symbolizer
apm-server                        endpoint-security.spec.yml       pf-elastic-symbolizer.spec.yml
apm-server.spec.yml               fleet-server                     pf-host-agent
apm-server.yml                    fleet-server.spec.yml            pf-host-agent.spec.yml

It exists in 8.16.x but is missing from 8.17.0, 8.17.0-SNAPSHOT, and 8.18.0-SNAPSHOT.

It was removed intentionally in 9.0 but the change in elastic agent was not backported as far as I can tell: #5481

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

[cmacknz]

Reproduces locally. cloud-defend was removed from the list of expected binaries to package in https://github.com/elastic/elastic-agent/pull/6042/files, likely as part of merge conflict resolution as it no longer exists on main.

[swiatekm]

I wonder what kind of test could've caught this. It's easy to miss changes in these kinds of lists during review. Maybe if we had separate test cases checking the container contents, it'd be harder to remove them accidentally this way?

[cmacknz]

Yes, we are missing a test that checks that the expected set of files exists in the container.

I know what the fix is and I'll have a PR up shortly.