Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose TransportApiResponse #145

Closed
pquentin opened this issue Jan 24, 2024 · 2 comments · Fixed by #160
Closed

Expose TransportApiResponse #145

pquentin opened this issue Jan 24, 2024 · 2 comments · Fixed by #160
Assignees
Labels
good first issue Good for newcomers

Comments

@pquentin
Copy link
Member

The documented way to call perform_request on a node is to expect a tuple in response, Tuple[ApiResponseMeta, bytes]. But the actual underlying type is TransportApiResponse:

class TransportApiResponse(NamedTuple):
    meta: ApiResponseMeta
    body: Any

As pointed out by @ywangd, It would make sense to expose it alongside other responses types and change the Nodes docs page to use it.

@pquentin pquentin added the good first issue Good for newcomers label Jan 24, 2024
@JessicaGarson JessicaGarson self-assigned this Mar 28, 2024
@JessicaGarson
Copy link
Contributor

Opened a PR here. I have some linting issues it seems. Should I be using Black for formatting?

@JessicaGarson
Copy link
Contributor

I figured out the formatting issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants