diff --git a/src/less/components/settings.less b/src/less/components/settings.less index 0ef77318b3..15ad39b85f 100644 --- a/src/less/components/settings.less +++ b/src/less/components/settings.less @@ -147,29 +147,52 @@ background: rgba(255, 255, 255, 0.1); padding: 10px; margin: 0 10px 10px 0; - display: flex; - justify-content: flex-start; cursor: pointer; + border-radius: 15px; &:hover { background: rgba(255, 255, 255, 0.15); } - h5, p { margin-bottom: 0; } - .avatar { - height: 100px; - width: 100px; - background-size: contain; - margin-right: 10px; + .header { + display: flex; + margin-bottom: 3px; + justify-content: flex-start; + + .avatar { + margin-right: 8px; + height: 40px; + width: 40px; + border-radius: 50%; + box-shadow: 0px 0px 6px 0px #101601; + } + + .info { + display: flex; + flex-direction: column; + + .name { + margin-bottom: 2px; + font-size: 14px; + font-weight: bold; + } + + .location { + font-style: oblique; + font-size: 12px; + } + } } - .details { - max-width: 190px; - overflow: auto; + .bio { + height: 58px; + word-break: break-word; + font-size: smaller; + overflow: scroll; } } } diff --git a/src/renderer/components/settings-credits.tsx b/src/renderer/components/settings-credits.tsx index 3c72c46177..bd05750472 100644 --- a/src/renderer/components/settings-credits.tsx +++ b/src/renderer/components/settings-credits.tsx @@ -53,13 +53,6 @@ export class CreditsSettings extends React.Component< const { contributors } = this.state; return contributors.map(({ name, avatar, url, login, location, bio }) => { - const maybeLocation = location ? ( -

📍 {location}

- ) : null; - const maybeBio = bio ? {bio} : null; - const style: React.CSSProperties = { - backgroundImage: `url(${avatar})`, - }; const onClick = () => shell.openExternal(url); return ( @@ -67,14 +60,17 @@ export class CreditsSettings extends React.Component< interactive={true} key={login} className="contributor" + elevation={2} onClick={onClick} > -
-
-
{name || login}
- {maybeLocation} - {maybeBio} +
+ avatar +
+

{name || login}

+ {location &&

📍 {location}

} +
+ {bio &&

{bio}

} ); }); diff --git a/tests/renderer/components/__snapshots__/settings-credits-spec.tsx.snap b/tests/renderer/components/__snapshots__/settings-credits-spec.tsx.snap index 30c142041b..dc32280b87 100644 --- a/tests/renderer/components/__snapshots__/settings-credits-spec.tsx.snap +++ b/tests/renderer/components/__snapshots__/settings-credits-spec.tsx.snap @@ -29,39 +29,40 @@ exports[`CreditsSettings component renders 1`] = ` >
-
-
- Felix Rieseberg -
-

- 📍 - San Francisco -

- +
- 🙇 ✨🌳 - +

+ Felix Rieseberg +

+

+ 📍 + San Francisco +

+
+

+ 🙇 ✨🌳 +

@@ -81,27 +82,28 @@ exports[`CreditsSettings component renders for contributors with less data 1`] = >
-
-
+
- felixrieseberg -
+

+ felixrieseberg +

+