From 593bd9bc2f1cb85bf8a7bc495c8ffb5f58d81d71 Mon Sep 17 00:00:00 2001
From: Daniel Haarhoff <d.haarhoff@elifesciences.org>
Date: Wed, 15 Jan 2025 15:10:28 +0000
Subject: [PATCH] Prefer Make targets over bash scripts

---
 Makefile         | 2 +-
 project_tests.sh | 5 -----
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
index 3f200142..de93e9a7 100644
--- a/Makefile
+++ b/Makefile
@@ -25,7 +25,7 @@ test: bring-up-app-and-queue-watcher
 	docker compose exec app vendor/bin/phpunit $(TEST)
 
 .PHONY: all-checks
-all-checks: bring-up-app-without-queue-watcher
+all-checks: bring-up-app-without-queue-watcher static-analysis test
 	docker compose exec app bash project_tests.sh
 
 .PHONY: stop
diff --git a/project_tests.sh b/project_tests.sh
index 63263936..de82e2bc 100755
--- a/project_tests.sh
+++ b/project_tests.sh
@@ -13,11 +13,6 @@ function cleanup {
 }
 trap cleanup EXIT
 
-vendor/bin/phpcs --standard=phpcs.xml.dist --warning-severity=0 -p src/ tests/ web/
-vendor/bin/composer-dependency-analyser
-vendor/bin/phpstan analyse
-vendor/bin/phpunit
-
 echo "Creating, deleting an index"
 bin/ci-lifecycle