You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems like the client returns a ValueError regardless of the type of error when handling requests: here
This error will be raised if the response status code is anything other than 200. Therefore we have no way of telling what the error is and whether we should retry the request using the same parameters. It would be better if more descriptive errors were returned here.
Better yet, a built-in retry mechanism would be great; perhaps by updating the Adapter to use an optional retry strategy as shown below. I can submit a PR if that's helpful.
Hey folks,
It seems like the client returns a
ValueError
regardless of the type of error when handling requests: hereThis error will be raised if the
response
status code is anything other than 200. Therefore we have no way of telling what the error is and whether we should retry the request using the same parameters. It would be better if more descriptive errors were returned here.Better yet, a built-in retry mechanism would be great; perhaps by updating the Adapter to use an optional retry strategy as shown below. I can submit a PR if that's helpful.
The text was updated successfully, but these errors were encountered: