Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no cels are listed for a set, the set number shouldn't be clickable #57

Open
emhoracek opened this issue Jul 8, 2018 · 5 comments
Open

Comments

@emhoracek
Copy link
Owner

Ophelia St Morphine by Satori is a good example.

Only the first set has any clothes:

screen shot 2018-07-08 at 1 08 01 pm

The rest are empty:
screen shot 2018-07-08 at 1 10 56 pm

This is intended by the artist to mean that those sets shouldn't be selectable, only the first is intended for view.

If you look through the setdata.js for this doll, you'll see that all the cels say "sets": [0].

I have some ideas for how to approach this, if you would like to try taking this issue but you're not sure where to start.

@emhoracek
Copy link
Owner Author

@hernandesdoug Would you like to try this one? I'm happy to help you get set up if you aren't sure how to get started.

@ghost
Copy link

ghost commented Jul 20, 2018

Hi @emhoracek Yes, I would.

@emhoracek
Copy link
Owner Author

@hernandesdoug I don't seem to have the process documented anywhere in this repository, but you can follow these slides from a recent workshop to get started on this issue. Please comment if you run into any trouble or confusion.

@ghost
Copy link

ghost commented Jul 20, 2018

Thank you @emhoracek I will fork the repo and work on it. I will let you know if I have any problem.

@emhoracek
Copy link
Owner Author

The person who originally claimed this has deleted their account, so this issue is up for grabs again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant