Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MapManager and related classes to Game SDK #5

Open
mudkipdev opened this issue Sep 16, 2024 · 2 comments
Open

Move MapManager and related classes to Game SDK #5

mudkipdev opened this issue Sep 16, 2024 · 2 comments

Comments

@mudkipdev
Copy link

This class is duplicated heavily between games.

@emortaldev
Copy link
Member

Note each game handles maps differently, not that it shouldn't be moved here.
E.g. ParkourTag loads all maps at start and then uses SharedInstances, Block Sumo creates all PolarLoaders at start and then creates new instances with that loader

@ZakShearman
Copy link
Member

Thinking about this, different gamemodes have:

  • Whether/not instances are shared or not
  • Different dimensions
  • Some have preloading, some don't. This could definitely be consistent.
  • Different time rate and time update settings on the Instance
  • Different 'map data' that is associated with each map and completely dynamic based on the gamemode.

I'm not saying no, it might be good to rework this but I'm not sure right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants