Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for plot_foi_estimates and plot_rhats #222

Open
jpavlich opened this issue Oct 21, 2024 · 2 comments
Open

Improve error messages for plot_foi_estimates and plot_rhats #222

jpavlich opened this issue Oct 21, 2024 · 2 comments
Assignees

Comments

@jpavlich
Copy link
Member

When passing constant seromodel as parameter to plot_foi_estimates and plot_rhats, it yields the following error

Error in plot_foi_estimates(seromodel, serosurvey) : 
  seromodel@name should start with either 'age' or 'time'

It is a little unintuitive, since it assumes the user know that seromodel@model_name begins with 'age' or 'time' for age or time models, respectively.

I would suggest changing it to "seromodel type must be 'age' or 'time'"

@jpavlich
Copy link
Member Author

jpavlich commented Oct 21, 2024

@ntorresd If you agree, you can assign me this issue. I will fix it as soon as #215 is merged into dev

@ntorresd
Copy link
Member

ntorresd commented Nov 3, 2024

#223 has been merged to dev. Please proceed with this @jpavlich.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants