Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using multiple clients causes segfault #7

Closed
graphiclunarkid opened this issue Dec 30, 2016 · 2 comments
Closed

Using multiple clients causes segfault #7

graphiclunarkid opened this issue Dec 30, 2016 · 2 comments

Comments

@graphiclunarkid
Copy link
Contributor

Reproduction steps:

  1. log in with client A
  2. enter a plain room with client A
  3. enter the encrypted room in client A
  4. log in with client B
  5. enter the same plain room with client B (A lot of "Room: Disconnected()" status messages appear in the plain room.)
  6. leave the plain room from client B
  7. write something in the plain room in client A
  8. write something in the encrypted room in client A (Client A crashes while writing.)

Same login on both clients.

It should be easy to check by copying "pidgin-home" to "pidgin-home2" and firing up "pidgin --config=pidgin-home2".

@inetic
Copy link
Member

inetic commented Jan 4, 2017

The crash is now fixed in the devel branch.

The problem "A lot of Room::Disconnected() status messages appear" I believe is in np1sec and is two fold. When np1sec-test-client receives RoomInterface::disconnected it does some cleanup but doesn't call Room::connect again, does np1sec try to connect implicitly and thus causing a loop?

The bigger problem is that np1sec relies on the server to assign unique username per user per room. This confuses np1sec when there are two clients with the same username (I believe it sees the other user as adversary who's trying to impersonate it and thus disconnects).

@redlizard FYI ^

@inetic
Copy link
Member

inetic commented Jan 6, 2017

This is now an np1sec issue: equalitie/np1sec#42

@inetic inetic closed this as completed Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants