Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room can't be destroyed inside Room::message_received #44

Open
inetic opened this issue Jan 12, 2017 · 0 comments
Open

Room can't be destroyed inside Room::message_received #44

inetic opened this issue Jan 12, 2017 · 0 comments

Comments

@inetic
Copy link
Member

inetic commented Jan 12, 2017

It causes double free of Conversations inside ConversationList.

We do mention that we can't call any room modifiers from inside Room's callbacks, but this is a bit different as the call to Room::message_received often results ConversationInterface callback being called. Implying that we can't destroy Room from inside those callbacks neither.

Possible solutions:

  • Fix it such that Room can be destroyed from inside ConversationInterface callbacks
  • Update documentation stating that it can't be done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant