Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A user already present in a chat joins the chat again. #47

Open
inetic opened this issue Jan 30, 2017 · 0 comments
Open

A user already present in a chat joins the chat again. #47

inetic opened this issue Jan 30, 2017 · 0 comments

Comments

@inetic
Copy link
Member

inetic commented Jan 30, 2017

This bug is exposed by the test_session_join_order test. The pseudo algorithm that the test implements goes like this:

  • user0 waits for user1 and user2 to enter the room.
  • Once user1 and user2 are in the room, user0 invites them both
  • When user1 receives the ConversationInterface::joined_chat event, the Conversation::participants() function returns [user0, user1, user2]
  • When user2 receives the ConversationInterface::joined_chat event, the Conversation::participants() function returns [user0, user1, user2]
  • Once everyone has joined everyone else's chat, a new user is created with name "new_guy" and is invited by user0 into the chat.
  • While user0, user1 and user2 are waiting for the "new_guy" to join the chat, user1 (or sometimes user2) receives a ConversationInterface::user_joined_chat("user2") (or user2 receives user_joined_chat("user1")).

The expected behavior is that user1 does not receive user_joined_chat("user2") event as user2 was already in the conversation (as known from the third bullet from the top).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant