Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWICM3 on aleph TCo1279-DART plus rudamentary intel compiler config. #1000

Open
wants to merge 21 commits into
base: release
Choose a base branch
from

Conversation

JanStreffing
Copy link
Contributor

On this branch I collect my work towards making aleph run with intel compiler and openmpi and cray mpich. While the compiling worked, neither ran the code. However the framework might still be useful at a later stage. Since cce + cray_mpich ultimatly worked when given enough nodes for TCo1279-DART, I do not intend to develop on from here.

Is this something that should be merged or not?

@JanStreffing JanStreffing added the enhancement New feature or request label Jul 20, 2023
@JanStreffing JanStreffing requested a review from mandresm July 20, 2023 13:11
@JanStreffing JanStreffing changed the title DRAFT: aleph with intel compiler AWICM3 on aleph TCo1279-DART plus rudamentary intel compiler config. Jul 27, 2023
@JanStreffing
Copy link
Contributor Author

JanStreffing commented Jul 27, 2023

This is the branch where AWI-CM3 runs on aleph with TCo1279-DART. This also has my attempts at intel+craympich and intel+openmpi. They did not work in the end, but I would not exclude that we try again at a later stage.

Ready for merge from my side.

@pgierz pgierz self-requested a review July 31, 2023 08:17
Copy link
Contributor

@mandresm mandresm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jan, I think it's okay to merge it so that it doesn't get lost. See some suggestions on the review below.

configs/machines/aleph.yaml Show resolved Hide resolved
Comment on lines +59 to +74
module_actions:
- "unload craype"
- "load craype/2.6.2"
- "load PrgEnv-cray/6.0.4"
- "load pbs"
- "load cray-mpich/7.7.3"
- "load craype-x86-skylake"
- "load cmake/3.14.0"
- "load cray-hdf5-parallel/1.10.2.0"
- "load cray-netcdf-hdf5parallel/4.6.1.3"
- "load cdo/1.9.5"
- "load fftw/2.1.5.9"
- "load nco/4.9.4"
- "load proj4/5.1.0"
- "load python/3.9.1"
- "list"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this can go outside in a general module_actions. Here you can place only the differences. It's a matter of taste, I find it easier to find what the difference are in between the options if in the choose blocks there are only differences.

If you want to give it a shot I recommend to use here add_module_actions and also variable definition and called by placeholders in the general module_actions like in the Albedo example:

https://github.com/esm-tools/esm_tools/blob/release/configs/machines/albedo.yaml#L127-L149

https://github.com/esm-tools/esm_tools/blob/release/configs/machines/albedo.yaml#L103-L125

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I place the defaults first, and then unload the craype, that might not work. The order can matter for module commands. Thus I try to keep them together as much as I can.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is indeed possible to keep the order if you follow the examples I pasted in the comment above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have time to give it a shot, if you have time to test it. Let me know what you prefer, doing it yourself or that I do it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might find some time tomorrow. Otherwise it would sit till after I'm back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm back and would have time to test.

configs/machines/aleph.yaml Show resolved Hide resolved
configs/machines/aleph.yaml Show resolved Hide resolved
Copy link
Contributor Author

@JanStreffing JanStreffing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised from my side.

@JanStreffing
Copy link
Contributor Author

Any more issues with this PR?

@nwieters
Copy link
Contributor

Hi @mandresm, @JanStreffing,
is this PR still to be merged? If so, can you please do a final approve? I tried to rerun the tests, but couldn't find where to restart them.

@nwieters nwieters removed their assignment Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants