minify support for the library?

[mihir-kandoi]

When minify is enabled in build.gradle, everything seems fine and the app builds but the provisioning library does not work correctly (for ex. scanning networks method simply does not return). Disabling minify fixes the issue BUT just because of this single library we can't use minify which when enabled cuts down our app size to half. I also see the example app is also not using minify. I request the developers to try with minify themselves and update the library with embedded ProGuard rules.

[KhushbuShah25]

Hi @mihir-kandoi ,
Will check and add the support so that apps can use with minify enabled.

[mihir-kandoi]

Hi @mihir-kandoi ,
Will check and add the support so that apps can use with minify enabled.

Thank you :)

[aa-v]

Is there a fix for this? Our minified app also fails.

[astimac]

If someone still needs this, try with this:

-dontwarn com.espressif.provisioning.**
-dontwarn espressif.**
-keep class com.espressif.provisioning.** {*;}
-keepclassmembers class com.espressif.provisioning.** {*;}
-keep class espressif.** {*;}
-keepclassmembers class espressif.** {*;}
-keep interface com.espressif.provisioning.** {*;}
-keep interface espressif.** {*;}
-keep public enum com.espressif.provisioning.** {*;}
-keep public enum espressif.** {*;}

[mihir-kandoi]

Thank you mate. I no longer need it but it will be super helpful for someone who does! @devs please bake this!

…

On Sun, Jul 9, 2023 at 8:28 PM Alexander Štimac ***@***.***> wrote: If someone still needs this, try with this: -dontwarn com.espressif.provisioning.** -dontwarn espressif.** -keep class com.espressif.provisioning.** {*;} -keepclassmembers class com.espressif.provisioning.** {*;} -keep class espressif.** {*;} -keepclassmembers class espressif.** {*;} -keep interface com.espressif.provisioning.** {*;} -keep interface espressif.** {*;} -keep public enum com.espressif.provisioning.** {*;} -keep public enum espressif.** {*;} — Reply to this email directly, view it on GitHub <#68 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACDMRNXGAFO6GT7ITLYUFSLXPLBIFANCNFSM57ZQNFCA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[KhushbuShah25]

Hi @astimac , thank you.
If possible, you can provide a PR for proguard rules, we'd be happy to review and merge.
Thanks!

[Klewerro]

Thanks @astimac - works like a charm 👍