Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMULATE_WITHOUT_LEDGER should check the value to 1 #448

Open
Tracked by #396
Ethnical opened this issue Jan 7, 2025 · 1 comment
Open
Tracked by #396

SIMULATE_WITHOUT_LEDGER should check the value to 1 #448

Ethnical opened this issue Jan 7, 2025 · 1 comment

Comments

@Ethnical
Copy link
Contributor

Ethnical commented Jan 7, 2025

For now the SIMULATE_WITHOUT_LEDGER is used to simulate without the ledger and this is very useful.
However, a "bug" can occurs when tasks writer wants to make this as more interactive.

So we would like to have the

  • SIMULATE_WITHOUT_LEDGER = 0 is disabled.
  • SIMULATE_WITHOUT_LEDGER = 1 is enabled.

For now, only if the SIMULATE_WITHOUT_LEDGER is set this will enable this and not check if the value is 0 or 1.

@sebastianst
Copy link
Member

I suggest we change the semantics to true and false so that it's the same as foundry forge script parsing of bool env vars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants