Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion: explicitly use Safe address for SIGNATURES_<SAFE-ADDR> env var #457

Open
sebastianst opened this issue Jan 10, 2025 · 0 comments
Open

Discussion: explicitly use Safe address for SIGNATURES_<SAFE-ADDR> env var #457

sebastianst opened this issue Jan 10, 2025 · 0 comments

Comments

@sebastianst
Copy link
Member

sebastianst commented Jan 10, 2025 •
edited
Loading

Do we want to start appending the affected Safe address that signatures are for for the just approve command, like SIGNATURES_<SAFE-ADDR>? This is similar to how we specify nonce overrides with SAFE_NONCE_<SAFE-ADDR>.

Then all sigs can be exported at once for a nested task and there's less chance of accidentally using wrong sigs and thinking that sigs are wrong.
@sebastianst sebastianst changed the title Discussion: explicitly use Safe address for SIGNATURE_<SAFE-ADDR> env var Discussion: explicitly use Safe address for SIGNATURES_<SAFE-ADDR> env var Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebastianst