From fb44efc85d747ab0a3398dcf0b9447a5580719f8 Mon Sep 17 00:00:00 2001
From: Jeremy Pople <jeremy@ethyca.com>
Date: Mon, 20 Jan 2025 14:38:43 -0800
Subject: [PATCH 1/2] further button tweaks

---
 .../hooks/useDiscoveredAssetsColumns.tsx          |  2 +-
 .../hooks/useDiscoveryResultColumns.tsx           |  2 +-
 .../tables/DiscoveryFieldBulkActions.tsx          | 11 ++++-------
 .../tables/DiscoveryTableBulkActions.tsx          | 15 +++++----------
 4 files changed, 11 insertions(+), 19 deletions(-)

diff --git a/clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useDiscoveredAssetsColumns.tsx b/clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useDiscoveredAssetsColumns.tsx
index 68b11c2310..f1172d4f90 100644
--- a/clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useDiscoveredAssetsColumns.tsx
+++ b/clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useDiscoveredAssetsColumns.tsx
@@ -30,7 +30,7 @@ export const useDiscoveredAssetsColumns = () => {
           dataTestId="select-all-rows"
         />
       ),
-      maxSize: 25,
+      maxSize: 40,
     }),
     columnHelper.accessor((row) => row.name, {
       id: "name",
diff --git a/clients/admin-ui/src/features/data-discovery-and-detection/hooks/useDiscoveryResultColumns.tsx b/clients/admin-ui/src/features/data-discovery-and-detection/hooks/useDiscoveryResultColumns.tsx
index c37b67bc72..64a5930403 100644
--- a/clients/admin-ui/src/features/data-discovery-and-detection/hooks/useDiscoveryResultColumns.tsx
+++ b/clients/admin-ui/src/features/data-discovery-and-detection/hooks/useDiscoveryResultColumns.tsx
@@ -101,7 +101,7 @@ const useDiscoveryResultColumns = ({
             dataTestId="select-all-rows"
           />
         ),
-        maxSize: 25,
+        maxSize: 40,
       }),
       columnHelper.accessor((row) => row.name, {
         id: "tables",
diff --git a/clients/admin-ui/src/features/data-discovery-and-detection/tables/DiscoveryFieldBulkActions.tsx b/clients/admin-ui/src/features/data-discovery-and-detection/tables/DiscoveryFieldBulkActions.tsx
index df0f7773b0..63e9f1e626 100644
--- a/clients/admin-ui/src/features/data-discovery-and-detection/tables/DiscoveryFieldBulkActions.tsx
+++ b/clients/admin-ui/src/features/data-discovery-and-detection/tables/DiscoveryFieldBulkActions.tsx
@@ -1,4 +1,4 @@
-import { CheckIcon, Flex, ViewOffIcon } from "fidesui";
+import { AntFlex as Flex, CheckIcon, ViewOffIcon } from "fidesui";
 
 import ActionButton from "~/features/data-discovery-and-detection/ActionButton";
 import {
@@ -31,12 +31,7 @@ const DiscoveryFieldBulkActions = ({
   };
 
   return (
-    <Flex
-      direction="row"
-      align="center"
-      justify="center"
-      data-testid="bulk-actions-menu"
-    >
+    <Flex data-testid="bulk-actions-menu">
       <div className="flex gap-2">
         <ActionButton
           title="Confirm all"
@@ -45,6 +40,7 @@ const DiscoveryFieldBulkActions = ({
           disabled={anyActionIsLoading}
           loading={isPromoteLoading}
           type="primary"
+          size="middle"
         />
         <ActionButton
           title="Ignore all"
@@ -52,6 +48,7 @@ const DiscoveryFieldBulkActions = ({
           onClick={() => handleIgnoreClicked([resourceUrn])}
           disabled={anyActionIsLoading}
           loading={isMuteLoading}
+          size="middle"
         />
       </div>
     </Flex>
diff --git a/clients/admin-ui/src/features/data-discovery-and-detection/tables/DiscoveryTableBulkActions.tsx b/clients/admin-ui/src/features/data-discovery-and-detection/tables/DiscoveryTableBulkActions.tsx
index 9cc2590f9e..a47f149e46 100644
--- a/clients/admin-ui/src/features/data-discovery-and-detection/tables/DiscoveryTableBulkActions.tsx
+++ b/clients/admin-ui/src/features/data-discovery-and-detection/tables/DiscoveryTableBulkActions.tsx
@@ -1,4 +1,4 @@
-import { CheckIcon, Flex, Text, ViewOffIcon } from "fidesui";
+import { AntFlex as Flex, CheckIcon, Text, ViewOffIcon } from "fidesui";
 
 import ActionButton from "~/features/data-discovery-and-detection/ActionButton";
 import {
@@ -35,19 +35,14 @@ const DiscoveryTableBulkActions = ({
   }
 
   return (
-    <Flex
-      direction="row"
-      align="center"
-      justify="center"
-      data-testid="bulk-actions-menu"
-    >
+    <Flex className="items-center" data-testid="bulk-actions-menu">
       <Text
         fontSize="xs"
         fontWeight="semibold"
         minW={16}
-        mr={6}
+        mr={4}
       >{`${selectedUrns.length} selected`}</Text>
-      <div>
+      <Flex className="gap-2">
         <ActionButton
           title="Confirm"
           icon={<CheckIcon />}
@@ -65,7 +60,7 @@ const DiscoveryTableBulkActions = ({
           onClick={() => handleIgnoreClicked(selectedUrns)}
           size="middle"
         />
-      </div>
+      </Flex>
     </Flex>
   );
 };

From dc5eefe46c2929b462b3e6335d97657874cc87e5 Mon Sep 17 00:00:00 2001
From: Jeremy Pople <jeremy@ethyca.com>
Date: Mon, 20 Jan 2025 15:38:02 -0800
Subject: [PATCH 2/2] update changelog

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index b4074dda63..b19e827edf 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -29,6 +29,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o
 
 ### Fixed
 - Updating mongodb connectors so it can support usernames and password with URL encoded characters [#5682](https://github.com/ethyca/fides/pull/5682)
+- Visual fixes for table header buttons [#5693](https://github.com/ethyca/fides/pull/5693)
 
 ## [2.53.0](https://github.com/ethyca/fides/compare/2.52.0...2.53.0)