Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for existing rebuilds for a legislature #37

Open
chrismytton opened this issue Aug 11, 2016 · 3 comments
Open

Check for existing rebuilds for a legislature #37

chrismytton opened this issue Aug 11, 2016 · 3 comments
Labels
Milestone

Comments

@chrismytton
Copy link
Contributor

In a similar spirit to everypolitician/countries_json_updater#5 when we receive a request to rebuild a legislature we should check if there's already a rebuild queued for that legislature. If there is then we don't need to queue the rebuild again.

@tmtmtmtm
Copy link
Contributor

This seems like fairly low-hanging fruit as part of speeding the rebuilder up (by reducing some rebuilds to zero!)

Other than a little bit of refactoring we should do to remove the duplication of doing this in two places, is this largely just a matter of replacing the perform_async calls with something that checks RebuilderJob.jobs first to see if there's already something with the same arguments?

@chrismytton
Copy link
Contributor Author

Other than a little bit of refactoring we should do to remove the duplication of doing this in two places, is this largely just a matter of replacing the perform_async calls with something that checks RebuilderJob.jobs first to see if there's already something with the same arguments?

Yep, that's pretty much it. I'll add this to my stack, should hopefully be fairly straightforward!

@chrismytton chrismytton self-assigned this Jan 10, 2017
@chrismytton chrismytton modified the milestone: Faster builds Feb 10, 2017
@chrismytton
Copy link
Contributor Author

Pull request for this is here #54 but need to revisit it and fix the tests so that they actually fail when expected.

@chrismytton chrismytton removed their assignment Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants