Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub access token to list of output redactions #68

Open
chrismytton opened this issue Feb 10, 2017 · 0 comments
Open

Add GitHub access token to list of output redactions #68

chrismytton opened this issue Feb 10, 2017 · 0 comments

Comments

@chrismytton
Copy link
Contributor

Problem

We added a CleanedOutput class in #64 which removes any mentions of the API key in the build output. We should add the GitHub access token to the list of redactions, so that it doesn't leak out. This will be even more valuable once #67 is done, since more of the build output will be sent to Rollbar if there's an error, so we don't want to leak credentials.

Proposed solution

Add github.access_token to the list of redactions when creating the CleanedOutput instance in app.rb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant