Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visiting the url of a webhook you don't own causes 500 error #78

Open
chrismytton opened this issue Jul 29, 2016 · 0 comments
Open

Visiting the url of a webhook you don't own causes 500 error #78

chrismytton opened this issue Jul 29, 2016 · 0 comments

Comments

@chrismytton
Copy link
Contributor

Problem

When signed in, trying to visit the url of someone else's webhook gives a 500 error.

Steps to reproduce

  1. Go to https://everypolitician-app-manager.herokuapp.com/ and sign in
  2. Visit the url of a webhook you don't own (but does exist), e.g. https://everypolitician-app-manager.herokuapp.com/webhooks/1
  3. 500 error

screen shot 2016-07-29 at 10 52 34

Proposed solution

I'm not sure exactly what's causing the 500 error, but that should be fixed and visiting other people's webhooks should return either a 404 (or possibly a 401).

Acceptance criteria

Following the steps to reproduce above should give a nice 404 page

Related issues

@chrismytton chrismytton changed the title Visiting the url of a webhook you don't causes 500 error Visiting the url of a webhook you don't own causes 500 error Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant