Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server/Client] Entry / Exit point definition for methods (low prio) #14

Open
doriancransac opened this issue Mar 22, 2016 · 4 comments
Assignees

Comments

@doriancransac
Copy link
Contributor

Will serve as a complement to the filters and the spawning of new trees starting at a given node.

Resulting gain : very powerful, additional filtering semantics for computation of sample percentages, among others.

@JSclient

@jeromecomte
Copy link
Contributor

Implemented PoC in branch feature_entrypoints.

Use the following node filter to set an entry point: "entry:djigger" => this will define all the nodes matching the expression "djigger" as entry points.

As a consequence "not entry:djigger" as node filter combined with the stackfilter defines a kind of exit point.

Please look at the implementation (NodeFilter.java) if you want to understand how it works.

@doriancransac
Copy link
Contributor Author

The "command line" approach is not a bad approach. I kind of like it.

What I had personally envisioned was something similar to the "Analize" click in agent mode, when popping a new window / frame. We could have an item in the right-click menu that says "Set as entry point in a new window" or something like that, which is more intuitive.

But the command line approach allows us to benefit from the operators, which is nice.

I guess they're both compatible anyways though.

One "bug" so far : since the "root object" remains the same, the result in terms of visualization in the block view is kind of crappy :

image

@doriancransac
Copy link
Contributor Author

doriancransac commented May 24, 2016

I think there might be another bug when combining the positive entry tags with the "and" and "or" operators:

image

image

In the first picture, I expect to not find anything (nothing matches that pattern), but instead I'm getting a match on the 2 last tokens.

In the second picture I should not see the top weblogic methods (weblogic.work package) and only start matching at ejb level.

The "not" operator alone and the "entry:x and not entry:y" seem to work fine however.

I'll send you my analysis session by email, since github refuses to upload my zip.

@doriancransac doriancransac added this to the R1.5 milestone May 24, 2016
@doriancransac doriancransac removed this from the R1.5 milestone Jun 13, 2016
@doriancransac
Copy link
Contributor Author

clearning milestone. we'll see later whether we want to finish this prior to 2.0 or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants