Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client] MinBoundCount > SamplesCount #74

Open
doriancransac opened this issue Jun 9, 2016 · 1 comment
Open

[Client] MinBoundCount > SamplesCount #74

doriancransac opened this issue Jun 9, 2016 · 1 comment
Assignees
Milestone

Comments

@doriancransac
Copy link
Contributor

http://denkbar.io/media/filer_public/d0/9b/d09b815b-4f9c-451a-a34a-7c9605af59dc/mincountpb.zip

image

@jeromecomte jeromecomte added this to the R1.5 milestone Jun 18, 2016
@jeromecomte
Copy link
Contributor

In your example the reason why MinCallCount > SampleCount is the stacktrace filter: the MinCallCount is calculated regardless of the stacktrace filter and is therefore invariant. The information displayed is therefore not wrong but confusing. Theoretically it would be possible to also apply the stacktracefilter to the MinCallCounts. Unfortunately this would require a radical change that is not possible anymore for R1.5.1. For the 1.5.1 we have 2 options:

  • Remove the feature
  • Let it as it is: not wrong and still useful but maybe confusing

I would be for the second option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants