Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs are not passing #194

Open
dipth opened this issue Feb 15, 2023 · 0 comments
Open

Specs are not passing #194

dipth opened this issue Feb 15, 2023 · 0 comments

Comments

@dipth
Copy link
Contributor

dipth commented Feb 15, 2023

Which SDK version are you using?

main

What's the issue?

Specs are failing with:

➜  facebook-ruby-business-sdk git:(main) ✗ bundle exec rspec
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.

An error occurred while loading ./spec/ad_object_spec.rb.
Failure/Error:
  RSpec.describe FacebookAds::AdObject do
  end

NameError:
  uninitialized constant FacebookAds::AdObject

  RSpec.describe FacebookAds::AdObject do
                            ^^^^^^^^^^
# ./spec/ad_object_spec.rb:19:in `<top (required)>'


Finished in 0.00004 seconds (files took 0.20585 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples

Furthermore looking at .github/workflows/ci.yml it doesn't even appear that specs are run as part of the CI-build.

When was the last time someone actually ran these specs?

Steps/Sample code to reproduce the issue

git clone https://github.com/facebook/facebook-ruby-business-sdk.git
cd facebook-ruby-business-sdk
bundle install
bundle exec rspec

Observed Results:

Specs fail with the following error:

An error occurred while loading ./spec/ad_object_spec.rb.
Failure/Error:
  RSpec.describe FacebookAds::AdObject do
  end

NameError:
  uninitialized constant FacebookAds::AdObject

  RSpec.describe FacebookAds::AdObject do
                            ^^^^^^^^^^
# ./spec/ad_object_spec.rb:19:in `<top (required)>'

Expected Results:

Specs should have passed successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant