Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename methods #122

Open
StefanUlbrich opened this issue Mar 12, 2020 · 2 comments
Open

Rename methods #122

StefanUlbrich opened this issue Mar 12, 2020 · 2 comments

Comments

@StefanUlbrich
Copy link

Hi
I tried to rename a function method but only the calls to the method were replaced-not the method declaration (leading to a pylint error). Did I do anything wrong?

query = (
    Query('./src/cool_project')
     .select_method("maximize")
     .rename("max_")
     .diff(interactive=True)
 )
thatch added a commit to thatch/Bowler that referenced this issue Mar 12, 2020
@thatch
Fix method rename, reported in facebookincubator#122
1611303
@thatch
Copy link
Contributor

thatch commented Mar 12, 2020

It looks like the bug relates to lack of types, bowler needs a fix something like thatch@1611303 (but with tests!)

@rajpratyush
Copy link

can i take up this issue
??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thatch @StefanUlbrich @rajpratyush