modify_argument loses the trailing , in call arguments

[perrinjerome]

With this code:

funccall(
  a='1',
  b='2',
  c='3',
)

and running this codmod:

$ bowler do 'Query(".").select_function("funccall").modify_argument("a", "aa")'
--- ./bug.py
+++ ./bug.py
@@ -1,6 +1,6 @@
 
 funccall(
-  a='1',
+  aa='1',
   b='2',
-  c='3',
+  c='3'
 )

the trailing comma on c=3, is not kept. I would expect that it is kept.

If we agree that would be the expected behavior and that you are willing to review a pull request I can try to take a look.

I think this happens around here:

Bowler/bowler/imr.py

Line 238 in 92c9eeb

parameters.insert_child(1, arguments)

and that this code could be changed to check if self.capture['function_arguments'][0].children[-1] is a comma and add it to arguments if that's the case.

Thanks !

[pioneerHitesh]

@perrinjerome can you assign this to me?

[perrinjerome]

@pioneerHitesh I cannot, I think only people with write access can do this