From 256243300a21542de4aa6ebd1bc82a36a4048244 Mon Sep 17 00:00:00 2001 From: Donny <130464015+defitricks@users.noreply.github.com> Date: Thu, 9 Jan 2025 04:03:47 +0200 Subject: [PATCH] docs: typo fix Update publish-image.sh (#2453) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Why is this change needed? The word "permissions" is used in plural form. However, it would be more accurate to use "**permission**" in singular, as it typically refers to general access rather than multiple specific rights in this context. ## Merge Checklist - [ ] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [ ] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [x] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. --- ## PR-Codex overview This PR focuses on correcting the grammatical error in the comments of the `scripts/publish-image.sh` file regarding permissions for Docker login. ### Detailed summary - Changed "necessary permissions" to "necessary permission" in the comment about Docker login. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` --- scripts/publish-image.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/publish-image.sh b/scripts/publish-image.sh index 2222088021..de7eab2e24 100755 --- a/scripts/publish-image.sh +++ b/scripts/publish-image.sh @@ -5,7 +5,7 @@ # # MUST be run from the root of the repository so the Docker build context is correct. # -# You must `docker login ...` first so that we have the necessary permissions to +# You must `docker login ...` first so that we have the necessary permission to # push the image layers + tags to Docker Hub. HUBBLE_VERSION=$(node -e "console.log(require('./apps/hubble/package.json').version);")