Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datrie-pyXX mixes external and internal libdatrie code #300

Closed
dmacks opened this issue Oct 28, 2018 · 3 comments
Closed

datrie-pyXX mixes external and internal libdatrie code #300

dmacks opened this issue Oct 28, 2018 · 3 comments
Assignees

Comments

@dmacks
Copy link
Member

dmacks commented Oct 28, 2018

Instrumenting the build with SetCPPFLAGS:-MD, I see that both the internal libdatrie (C library) and the python glue code (C code wrapping the C library) are using fink's libdatrie1 headers rather than the ones supplied as part of the internal libdatrie library (but still using the internal *.c). Debian's package has a patch to use the external lib. I filed an upstream datrie-py bug about it (pytries/datrie#56).

The reason for the header misuse is that setuputils appends flags rather than prepending, so the default CPPFLAGS (-I%p/include) take priority over anything setup.py adds. One could also argue that this is a long-standing bug in setuputils.

@danielj7
Copy link
Member

Gah, you're right. Stupid python. I tried the debian patches and they do allow it to build using libdatrie1, but there are 6 test failures, while all tests pass with the internal libdatrie. I'll have to see if its version is different from our package.

@danielj7
Copy link
Member

Ok #301 seems to fix it.

@danielj7
Copy link
Member

#301 now merged to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants