-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create redshift limit one macro #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-avinash a few small change requests. Also, can you please provide some validations to show that the union data update is working as expected here. It would be great to see:
- This properly fills 1 row of nulls when the table isn't present and the destination is Redshift and retains the datatype.
- This properly fills 0 rows if the table isn't present and the destination is anything other than Redshift.
- The model works as expected when the table is present and the destination is Redshift and any other warehouse.
models/tmp/stg_shopify__abandoned_checkout_discount_code_tmp.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-joemarkiewicz Thanks for the validation call-out. See the ticket for validations. This PR is ready for re-review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Co-authored-by: Avinash Kunnath <[email protected]>
…an/dbt_shopify_source into bugfix/redshift-limit-one
PR Overview
This PR will address the following Issue/Feature: Internal ticket
This PR will result in the following new package version:
v0.15.0 - staging model results will be different for redshift users potentially (1 row instead of 0 for empty rows)
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Under the Hood
shopify_union_data
macro to accommodate Redshift's treatment of empty tables.null
row for Redshift destinations.varchar
. This throws errors in downstream transformations in theshopify
package. The 1 row will ensure that Redshift will respect the package's datatype casts.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
See concurrent transform PR.
If you had to summarize this PR in an emoji, which would it be?
🇪🇺