Bench new-site doesn't work with empty passwords, flags error: Unexpected Extra Argument.

[ayosafacundo]

erpnext_quick_install/erpnext_install.sh

Line 369 in 84340ef

bench new-site $site_name --db-root-password $sqlpasswrd --admin-password $adminpasswrd

Expected functionality:
It should check if you've inputted a password or left empty and take that into account when setting up a new site.

It executes this command: bench new-site $site_name --db-root-password $sqlpasswrd --admin-password $adminpasswrd
which for empty passwords turns out to be: bench new-site $site_name --db-root-password --admin-password, returning unexpected extra argument error.

[flexcomng]

AFAIK, Frappe does not allow empty passwords and MariaDB definitely does not allow empty passwords so you have to set your root/MariaDB and administrator passwords in order to complete an install.

[ayosafacundo]

I was able to do it setting a password, but it was weird that the bash script allowed me to not set any password and then delivered an unexpected extra argument error blaming bench. Would be nice for the bash script to actually enforce a password.