Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Replace selectable text #723

Closed
wants to merge 24 commits into from
Closed

Replace selectable text #723

wants to merge 24 commits into from

Conversation

OlegZaimNLT
Copy link
Contributor

@OlegZaimNLT OlegZaimNLT commented Jun 30, 2022 •
edited by guidezpl
Loading

Removed all SelectableText. Added a SelectionArea per MaterialApp and one for settings.
Fixes #698
Clone #699

OlegZaimNLT and others added 20 commits May 26, 2022 18:54
@OlegZaimNLT
Migrate all SelectableText to SelectionArea.
125b5ed
@OlegZaimNLT
Revert changes
39c358a
@OlegZaimNLT
Added SelectionArea one per MaterialApp and replaced each SelectableT…
29e0d8f 
…ext to Text.
@OlegZaimNLT
Added SelectionArea one per MaterialApp and replaced each SelectableT…
fb89715 
…ext to Text.
@OlegZaimNLT
Added comma for better formatting. Added missing ApplyTextOptions to …
2dc66ce 
…the Srine and Start apps.
@OlegZaimNLT
Added comma for better formatting. Added missing ApplyTextOptions and…
871c83a 
… SelectionAreas.
@OlegZaimNLT
Added comma for better formatting. Added missing ApplyTextOptions and…
c287b80 
… SelectionAreas.
@guidezpl
small fixes
cf01179
@guidezpl
remove unused imports
5b3ae37
@OlegZaimNLT
Added Selection Areas for the demos.
e48a249
@guidezpl
Merge branch 'master' into replace-selectable-text
84e290d
@guidezpl
fix
00d2aea
@guidezpl
formatting
3421788
@guidezpl
update goldens
c754b4a
@guidezpl
Merge branch 'main' into pr/699
af7df2a
@dependabot
Bump github/codeql-action from 2.1.12 to 2.1.14
f9f0185 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.12 to 2.1.14.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@27ea8f8...41a4ada)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@OlegZaimNLT
Merge pull request #1 from OlegZaimNLT/dependabot/github_actions/gith…
590e38c 
…ub/codeql-action-2.1.14

Bump github/codeql-action from 2.1.12 to 2.1.14
@OlegZaimNLT
Merge branch 'replace-selectable-text' of https://github.com/olegzaim…
2361a0d 
…/gallery into replace-selectable-text
@OlegZaimNLT
Merge branch 'flutter:main' into main
7ea65c4
@OlegZaimNLT
Merge branch 'main' of github.com:OlegZaimNLT/gallery into replace-se…
0b0bca7 
…lectable-text

� Conflicts:
�	lib/studies/rally/login.dart
�	test_goldens/goldens/demo_desktop_dark.png
�	test_goldens/goldens/demo_desktop_light.png
�	test_goldens/goldens/shrine_desktop.png
�	test_goldens/goldens/shrine_mobile.png
@OlegZaimNLT
Copy link
Contributor Author

OlegZaimNLT commented Jul 8, 2022 •
edited
Loading

@guidezpl Hey, could you check what happen with the test checks?

@guidezpl
Copy link
Member

guidezpl commented Jul 8, 2022

I don't have bandwidth to investigate at the moment. I encourage you to try to repro the error locally.

@guidezpl
Copy link
Member

@chunhtai, do you have a clue as to the following error?

[APP] Bad state: A RenderObject does not have any constraints before it has been laid out.
[APP]     at Object.wrapException (http://localhost:9999/main.dart.js:8823:17)
[APP]     at RenderParagraph.get$constraints (http://localhost:9999/main.dart.js:129964:17)
[APP]     at RenderParagraph.getBoxesForSelection$1 (http://localhost:9999/main.dart.js:131589:107)
[APP]     at _SelectableFragment.get$_paragraph$_rect (http://localhost:9999/main.dart.js:132050:20)
[APP]     at _SelectableFragment.getTransformTo$1 (http://localhost:9999/main.dart.js:132025:57)
[APP]     at _SelectableRegionContainerDelegate._compareScreenOrder$2 (http://localhost:9999/main.dart.js:166659:49)
[APP]     at tear_off.<anonymous> (http://localhost:9999/main.dart.js:9142:45)
[APP]     at Object.Sort__insertionSort (http://localhost:9999/main.dart.js:7981:37)
[APP]     at Object.Sort__doSort (http://localhost:9999/main.dart.js:7971:11)
[APP]     at Object.Sort_sort (http://localhost:9999/main.dart.js:7967:9)

@chunhtai chunhtai self-requested a review July 18, 2022 17:54
@chunhtai
Copy link

it looks like some layout order issue, it looks like some components are not laid out with in the same frame they were added to the widget tree. It will be good if there is a minimum repro

@chunhtai
Copy link

chunhtai commented Jan 4, 2023 •
edited
Loading

I think we will no longer need this once this is fixed flutter/flutter#104547

@chunhtai chunhtai closed this Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chunhtai chunhtai Awaiting requested review from chunhtai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace SelectableText with a small number of SelectableAreas
3 participants
@OlegZaimNLT @guidezpl @chunhtai